Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] acs override for virtualization with gpu passthrough #2

Closed
elevenhsoft opened this issue Dec 20, 2024 · 5 comments
Closed

[patch] acs override for virtualization with gpu passthrough #2

elevenhsoft opened this issue Dec 20, 2024 · 5 comments

Comments

@elevenhsoft
Copy link

Hi,

Could you please consider adding ACS Override Patch to this kernel for future Bazzite releases? Right now Bazzite have easy ujust scripts for setup virtualization even with gpu passthrough. The problem is when using multiple GPU and passing through one of them in the same groups of IOMMU.

This patch solves this problems. Before it was present in fsync kernel until some of the relases, I don't remember. It should not harm much since you need to enable this patch on your userspace with kernel params. So security should not be affected.

Are there any more problems with it to be not added? It's really, really helpful in many cases of GPU Passthrough.

@HikariKnight
Copy link

HikariKnight commented Dec 20, 2024

Hi, the ACS override is a hacky workaround for motherboards with bad IOMMU groups and will have to be fixed constantly for the new kernel versions as things changes.
It was also removed from fsync last year due to it causing stability issues for other hardware.

I would instead recommend in the future to just get boards that tend to have the ACS patch as part of their firmware (asrock)

asrock is one of the few motherboard vendors that are GPU passthrough friendly.

@elevenhsoft
Copy link
Author

Yeah, I'm aware of those motherboards. This is best solution but comes with some additional costs ($$). For now ACS Patch seems awesome, actually I'm always tend to use kernels with this patch, for example Xanmod or Liquorix, or Zen and never had any problems with stability. Maybe the issues are with many more patches in kernel others than acs, I don't know.

Would be nice to see it in Bazzite anyway. From my experience, there was not stability issues or anything like that. Maybe some other setups have.

Bazzite is immutable so low level changes like kernels sounds hard to do and also not recommended. But if you are won't add this patch, well. Sad but I understand :)

@antheas
Copy link
Contributor

antheas commented Dec 24, 2024

You cant change the kernel on bazzite dont try. I have tried.

In any case, post the patch and I will review it.

But if it causes instability for other hardware it cannot be added unfortunately

@elevenhsoft
Copy link
Author

Hello @antheas ,
Thanks for your consideration. I'm used to use patch from linux-vfio and linux-vfio-lts AUR packages.
For kernel 6.12 there is it: https://aur.archlinux.org/cgit/aur.git/tree/1001-6.8.0-add-acs-overrides.patch?h=linux-vfio
And for LTS: https://aur.archlinux.org/cgit/aur.git/tree/1001-6.6.7-add-acs-overrides.patch?h=linux-vfio-lts

There is few custom kernels which adds this patch. For example, Xanmod, Liquorix, Zen, and few more, even Cachy I think (for Fedora). On every kernel, I did not find any issues. Also, you need to enable this patch with kernel params, so on normal system, you won't need to use it, so it will be disabled. I don't know what issues it can make, but I heard that also, so .... Please review it and consider :) Thank you.

Happy Xmas!

@antheas
Copy link
Contributor

antheas commented Dec 25, 2024

Seems harmless enough so I added it

https://github.com/hhd-dev/kernel-bazzite/releases/tag/6.12.6-203

@antheas antheas closed this as completed Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants