Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Remove some unnecessary explicit fields in sample CR higresscontroller #2

Open
Charlie17Li opened this issue Jul 30, 2023 · 0 comments
Labels

Comments

@Charlie17Li
Copy link
Collaborator

Charlie17Li commented Jul 30, 2023

Background

There are many unnecessary explicit fields in sample CR :

--- a/config/samples/operator_v1alpha1_higresscontroller.yaml
+++ b/config/samples/operator_v1alpha1_higresscontroller.yaml
@@ -18,24 +18,11 @@ spec:
     image:
       repository: "higress-registry.cn-hangzhou.cr.aliyuncs.com/higress/higress"
       tag: "1.1.0"
-      imagePullPolicy: "IfNotPresent"
     gatewayName: "higress-gateway"
     ingressClass: "higress"
-    sdsTokenAud: "istio-ca"
   pilot:
     name: "pilot"
     image:
       repository: "higress-registry.cn-hangzhou.cr.aliyuncs.com/higress/pilot"
       tag: "1.1.0"
-      imagePullPolicy: "IfNotPresent"
-    env:
-      PILOT_SCOPE_GATEWAY_TO_NAMESPACE: "false"
-      PILOT_ENABLE_METADATA_EXCHANGE: "false"
-      PILOT_ENABLE_CROSS_CLUSTER_WORKLOAD_ENTRY: "false"
-      VALIDATION_ENABLED: "false"
-    traceSampling: "1.0"
-    keepaliveMaxServerConnectionAge: 30m
-    clusterDomain: "cluster.local"
-    oneNamespace: false
-    enableProtocolSniffingForOutbound: true
-    enableProtocolSniffingForInbound: true
+    clusterDomain: "cluster.local"

To get started, we should minimize unnecessary field Settings and we should remove the red parts as much as possible

@Charlie17Li Charlie17Li added the enhancement enhance label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant