Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite/Refactor parts of RESTClient impl. #2022

Open
1 task done
syncblaze opened this issue Aug 18, 2024 · 1 comment
Open
1 task done

Rewrite/Refactor parts of RESTClient impl. #2022

syncblaze opened this issue Aug 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@syncblaze
Copy link
Contributor

Summary

There is a lot of inconsistency which build up over the last few years in the way the diffrent rest methods are implemented. One big inconsistency for example is handling value of function parameters.
I will leave a example for this here you can see that the None & undefined check is doubled.
IMG_0192

Requirements

#2021 needs to be merged first before this can makes sense doing

Why is this needed?

Consistency is nice and doubled checks are bad for developer expierence and prob a small bit performance.

Ideal implementation

Looking through most of the rest functions and refactor some of them where needed.

Checklist

  • I have searched the issue tracker and have made sure it's not a duplicate. If it is a follow up of another issue, I have specified it.
@syncblaze syncblaze added the enhancement New feature or request label Aug 18, 2024
@syncblaze
Copy link
Contributor Author

this is just a small reminder for me for doing this so dont worry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant