Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for utilities.ux #193

Merged
1 commit merged into from
Sep 17, 2020
Merged

Added tests for utilities.ux #193

1 commit merged into from
Sep 17, 2020

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Sep 16, 2020

  • Fix issues detecting and outputing new version from PyPI

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

#47

@davfsa davfsa requested review from a user and FasterSpeeding September 16, 2020 18:49
@davfsa davfsa self-assigned this Sep 16, 2020
@davfsa davfsa added bug Something isn't working enhancement New feature or request testing Improvements or additions to tests labels Sep 16, 2020
@davfsa davfsa added this to the 2.0.0 milestone Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #193 into master will increase coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   79.64%   80.24%   +0.60%     
==========================================
  Files          80       80              
  Lines       10389    10399      +10     
  Branches     1317     1321       +4     
==========================================
+ Hits         8274     8345      +71     
+ Misses       2035     1974      -61     
  Partials       80       80              
Impacted Files Coverage Δ
hikari/api/rest.py 100.00% <ø> (ø)
hikari/presences.py 100.00% <ø> (ø)
hikari/utilities/ux.py 100.00% <100.00%> (+70.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b79731...e5c820e. Read the comment docs.

@ghost
Copy link

ghost commented Sep 16, 2020

Holding off this for a little bit as im about to change these files with a bug fix.

@ghost
Copy link

ghost commented Sep 16, 2020

might need to re-run the CI.

  - Fix issues detecting and outputing new version from PyPI
@davfsa
Copy link
Member Author

davfsa commented Sep 17, 2020

Rebased and fixed tests that failed because of it 👍

@ghost ghost merged commit 85e3d2b into hikari-py:master Sep 17, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request testing Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant