Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum tests #332

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Enum tests #332

merged 1 commit into from
Oct 30, 2020

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Oct 29, 2020

  • Remove unreachable and duplicate code
  • Fixed some logic

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

#47

@davfsa davfsa added bug Something isn't working enhancement New feature or request testing Improvements or additions to tests labels Oct 29, 2020
@davfsa davfsa added this to the 2.0.0 milestone Oct 29, 2020
@davfsa davfsa requested a review from FasterSpeeding October 29, 2020 09:21
@davfsa davfsa self-assigned this Oct 29, 2020
@davfsa davfsa force-pushed the task/more-testing branch from 0150bdd to ed80f04 Compare October 29, 2020 11:10
@davfsa
Enum tests
8c2dcce 
   - Remove unreachable and duplicate code
   - Fixed some logic
@davfsa davfsa force-pushed the task/more-testing branch from ed80f04 to 8c2dcce Compare October 29, 2020 20:59
@davfsa
Copy link
Member Author

davfsa commented Oct 29, 2020

@FasterSpeeding all fixed

@davfsa davfsa merged commit 0a41cb6 into hikari-py:master Oct 30, 2020
@davfsa davfsa deleted the task/more-testing branch October 30, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FasterSpeeding FasterSpeeding FasterSpeeding approved these changes

Assignees

@davfsa davfsa

Labels
bug Something isn't working enhancement New feature or request testing Improvements or additions to tests
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davfsa @FasterSpeeding