Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HipsTileMeta returns the four corners of the tile clockwise #145

Open
almicol opened this issue Nov 21, 2019 · 1 comment
Open

HipsTileMeta returns the four corners of the tile clockwise #145

almicol opened this issue Nov 21, 2019 · 1 comment

Comments

@almicol
Copy link

almicol commented Nov 21, 2019

The example in your documentation:
https://hips.readthedocs.io/en/latest/api/hips.HipsTileMeta.html
shows a returned skycoord_corners with the corners listed clockwise.

The convention within the Virtual Observatory is that internal part of a polygon is on the left of each side as seen from the center of the sphere. Because of that a polygon containing a certain region (e.g. a Healpix tile) must be written counterclockwise.

It would hence seem useful to have HipsTileMeta outputing the corners counterclockwise, to avoid any confusion. Could that be done? Thanks!

PS: The effect of a wrong headedness is here described: If I build a polygon using the corners ordered clockwise, that is, in the order provided by skycoord_corners, and query the ESO obscore service for any product contained in that polygon, I would get exactly the opposite of what I'd expect: the result set would contain all the products with footprints "outside" of the provided polygon.

@tboch
Copy link
Member

tboch commented Nov 21, 2019

Hi Alberto.
I agree, this sounds like a sensible request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants