certbot cron installed even if letsencrypt flag is: false

[sirup]

There is a missing when statement in tasks/letsencrypt.yml for task:

- name: Insert cert-bot renew in crontab

It is missing when:

when: - item.value.letsencrypt | default(False)

Leads to high CPU usage because the cron job in installed but cannot be used.
Happens when you do not use letsencrypt:

letsencrypt: false

[ivareri]

Would it not be better to only include tasks/letsencrypt.yml when letsencrypt is set to true?

Inserting when: item.value.letsencrypt | default(False) after line 193 in main.yml should fix this.

[gthieleb]

Same here with config:

  vars:
    nginx_revproxy_sites:
      default:
        ssl: false
        letsencrypt: false
      prometheus:
        domains:
        - example.com
        upstreams:
        - { backend_address: 127.0.0.1, backend_port: 9090 }
        ssl: false
        letsencrypt: false

TASK [hispanico.nginx_revproxy : Insert cert-bot renew in crontab] **************************************************************************************************************************
fatal: [********]: FAILED! => {"changed": false, "msg": "Failed to find required executable crontab in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin"}