Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Tampermonkey Permission Request #49

Open
floriankilian opened this issue Oct 9, 2023 · 4 comments
Open

No Tampermonkey Permission Request #49

floriankilian opened this issue Oct 9, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers priority High priority task

Comments

@floriankilian
Copy link

floriankilian commented Oct 9, 2023

No Tampermonkey Permission Request

Describe the Bug
A clear and concise description of what the bug is.

Steps to Reproduce
Steps to reproduce the behavior:
Installing a new X-Tracker Tampermonkey script (in my case #16). Neither during install nor the first visit on the tweets page there was a prompt requesting permission to send data to X-Tracker.

Expected Behavior
"A prompt will appear, asking for your permission to send data to X-Tracker. Click "Allow" to start tracking the tweet metrics." (link)

Environment (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 17.0.5938.92
    • Logged in as a user on the website

Additional Context
The Tampermonkey script runs (as it reloads the tweets page), however there is also no data being displayed on the tracked tweet. So not sure if the prompt requesting was not executed by Tampermonkey or a link is missing in the user script?

No update of data

As far as I can tell the script is running (I can see how it is refreshing the website), however the tracked tweets are shown as never tracked, and the script has also a warning (as added in the comment)
image

@floriankilian floriankilian added the bug Something isn't working label Oct 9, 2023
@floriankilian
Copy link
Author

With your newest update it shows the three tweets as "never tracked" (16/17/18)

Also just saw this warning in the Tampermonkey script within the Tampermonkey plugin:
image

eslint: no-undef - 'jQuery'is not defined.

@floriankilian
Copy link
Author

floriankilian commented Oct 9, 2023

-> just changed my language settings to english, and now it prompted me for permission and it's tracking! :)

image

How to change display language on twitter: https://help.twitter.com/de/managing-your-account/how-to-change-language-settings

@hoblin
Copy link
Owner

hoblin commented Oct 9, 2023

Right, the script looks for the aria-label attributes and expects English text. Good catch. Thanks!

@hoblin hoblin added good first issue Good for newcomers priority High priority task labels Oct 9, 2023
@hoblin
Copy link
Owner

hoblin commented Oct 9, 2023

We can add an object with collection of strings and then detect page locale

const preset = {
en: {like: 'like', // etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority High priority task
Projects
None yet
Development

No branches or pull requests

2 participants