Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publication links broken #25

Open
whoburg opened this issue May 15, 2017 · 2 comments
Open

publication links broken #25

whoburg opened this issue May 15, 2017 · 2 comments
Assignees

Comments

@whoburg
Copy link
Contributor

whoburg commented May 15, 2017

Publication links take you to a truncated URL.

@1ozturkbe can you take a look at this asap?

image

@edfan
Copy link

edfan commented May 15, 2017

Thought this would be simple, but it's a pretty weird bug- it doesn't occur if I build with jekyll locally. My guess is that it's something with baseurl (seems like it shouldn't end in a slash) but it's hard to tell what GitHub Pages' behavior will be.

Some alternatives that might work (using gassolar.pdf):
/publications/gassolar.pdf
{{ site.baseurl }}publications/gassolar.pdf
{{ site.url }}/publications/gassolar.pdf
http://hoburg.mit.edu/publications/gassolar.pdf

I've put in a PR for the last one, although it's arguably the worst from a modularity standpoint.

@whoburg
Copy link
Contributor Author

whoburg commented May 15, 2017

ok good hotfix, let's leave this open to find a more elegant solution

for what it's worth I think this worked at one point, so maybe a new version of something isn't playing nice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants