Upgrades to intl-tel-input:14.0.0 and fixes protractor tests #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitpit
changed the title
|
protractor tests failed because rate limit of github is reached... I will give a try tomorrow |
pitpit
changed the title
pitpit
changed the title
pitpit
commented
Oct 9, 2018
| install: | ||
| - "npm install" | ||
| - "./node_modules/bower/bin/bower install" | ||
| before_script: | ||
| - "export DISPLAY=:99.0" | ||
| - "sh -e /etc/init.d/xvfb start" |
There was a problem hiding this comment.
xvfb is not needed anymore, because we're using firefox headless mode
|
hi @bighappyface, could you add a github access token to travis to avoid rate limit in travis ? I fixed all tests but it continues to fail because that rate limit reached... |
|
up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #126
End-to-end test with protractor and firefox were broken :
I try updating protractor to each major latest version (4.0.14, 3.3.0, 2.5.1) but no one supports firefox 56.0.2.
I had to update protractor to latest release: 5.4.1 using gecko webdriver 0.19.0.
Unfortunately [email protected] is only supported on node>=4.9.x, so I replaced test coverage from Node from 0.12 to 5.x by Node from 6.x to 10.x in .travis.yml