Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have more control about windows being brought to front #147

Open
samtrek opened this issue Jan 4, 2023 · 6 comments
Open

Have more control about windows being brought to front #147

samtrek opened this issue Jan 4, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@samtrek
Copy link

samtrek commented Jan 4, 2023

I have observed that group messages from the plugin are automatically shown, while normal messages are kept in the background: that is messaging windows are not raised, is there anyway messages from groups can also be made to remain to remain in the background or show notification until the pidgin icon is clicked?

Seems status broadcast has also been re-enabled, this at times causes barrage of message from contacts, can it be included in the option again to disable status contacts or find a new solution if disabling status contacts is conflicting with the overall functioning of the plugin.

@hoehermann
Copy link
Owner

I do not know any way to control the behaviour of the window focus. In fact, I do not know why it is different for chats and direct conversations at all. For normal incoming messages, I call the official functions serv_got_joined_chat or serv_got_im. Both call purple_conversation_new, create_conversation, pidgin_conv_new,private_gtkconv_new, pidgin_conv_placement_place, conv_placement_new_window, pidgin_conv_window_show, and finally gtk_widget_show. When displaying the copies of outgoing "synced" (sent from another device) messages, the serv_* functions are omitted, though after that, the code path should be the same. I could build Pidgin with debug symbols to investigate this in detail, but the chances for me actually doing that are rather slim.

I was using a pretty daft comparison for filtering out the status broadcasts. I noticed there was an official method to do it. Apparently I am using it wrong. I hope I can look into it this weekend. But nice to know receiving status broadcasts are no longer resulting in a crash. I still have no idea why my phone (and to that extent my linked Pidgin) will not receive any status broadcasts, so I cannot test it. Does that "barrage of messages" occur once after linking or every time when connecting and catching up?

@samtrek
Copy link
Author

samtrek commented Jan 5, 2023

  1. The first issue raised can be worked on later when you have time, or you can relabel it for those who are more knowledgeable with pidgin. I have little or no knowledge in this field.
  2. If the option to disable status broadcast that was in the previous version can be re-enable, I will b e glad. The reason is that the status window continue to raise itself at inconvenient time barrage of message = some people decide to post several messages on their status wall at time.

@hoehermann
Copy link
Owner

Thank you for your feedback and patient testing. 1513f88 now contains an option to ignore status broadcasts (they are ignored by default).

@samtrek
Copy link
Author

samtrek commented Jan 6, 2023

The option to disable status broadcast is back in 1513f88. Thank you for your effort towards the development of the plugin. Will be closing this issue hope you will one time in the future take a look at the notifications for group messages as discussed above.

@samtrek samtrek closed this as completed Jan 6, 2023
@hoehermann
Copy link
Owner

Thank you for the feedback. For reminding me about the window presentation, I want to keep this issue open. I tend to completely forget about closed issues. 😅

@hoehermann hoehermann reopened this Jan 6, 2023
@hoehermann hoehermann changed the title Improvement on group message and status broadcast handling Have more control about windows being brought to front Jan 6, 2023
@hoehermann hoehermann added the enhancement New feature or request label Jan 6, 2023
@samtrek
Copy link
Author

samtrek commented Jan 6, 2023

Did not want to put too much pressure on you, so I decided to close it since you said you may likely not work on it, with or without it is still great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants