Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic for purple-3 #54

Open
SolarAquarion opened this issue May 13, 2020 · 4 comments
Open

Add logic for purple-3 #54

SolarAquarion opened this issue May 13, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Someone else is free to do this

Comments

@SolarAquarion
Copy link

It currently fails to build because it looks for purple, and not purple-3. Perhaps add some logic to the MAKEFILE to say PURPLE=purple-3

@hoehermann
Copy link
Owner

I want to support purple 3 one day. I mainly write this plug-in so I can use it myself. And I don't use Pidgin 3, yet. Contributions are welcome, of course. :)

@hoehermann hoehermann added enhancement New feature or request help wanted Someone else is free to do this labels May 13, 2020
@SolarAquarion
Copy link
Author

I have an initial patch on my system, but, i don't know how to go in the logic of pidgin 3 because some of the headers have been removed

@hoehermann
Copy link
Owner

Yes, that describes the challenge quite well. Preprocessor switches are necessary to discriminate the version numbers. You can look at these projects of EionRobb's for examples on how to add support for both libpurple versions.

@hoehermann
Copy link
Owner

I looked into this the other day. I actually managed to build https://github.com/hoehermann/purple-signald/tree/purple-3 against purple-3. It has a number of issues, but nothing too severe. However, the purple-3 developers said that the purple-3 interfaces are not mature, yet: https://discord.com/channels/351558764417122305/624712166968131595/1013234593240973352 Relying on them would be unwise. I put this on hold until purple-3 is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Someone else is free to do this
Projects
None yet
Development

No branches or pull requests

2 participants