Mis-characterisation of SVG and image as generated

[hoijui]

In GitLab by @julianstirling on Feb 25, 2022, 17:27

SVG is the native file format of Inkscape and is a valid source file. It should not be flagged as a generated file.

Similarly jpg files are generally photos which if they are in documentation the cannot be generated by a CI. Similarly some PNGs (for example high resolution renders) also generally takes specialist computing hardware and cannot be generated on-the-fly by a CI.

[hoijui]

I am a bit twisted about this one. I think it probably needs adjustment in the way it is reported. Right now (sample):

---

• Might be generated

  • LIGHT - Possibly generatable files found. Please consider removing them:

    • res/asset/media/img/3D-printer.png
    • res/asset/media/img/x-y-control-plan.png

---

This shows that this is only a minor thing (with "LIGHT"),
but it still shows the check as failed (no tick in checkbox).
That is indeed not optimal. Possible ways to improve:

1. Only fail (no tick in checkbox) for issues above level "LIGHT"
2. instead of boolean check states (passed/not-passed), introduce more (named) states, or a value from 0 to 10 (or 0.0 to 1.0)
3. Use solution 1., but allow to enable --pedantic mode, which would result in the current behavior
4. ... any other ideas?

[hoijui]

marked this issue as related to #12