Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow objects to input data into EdfReader #174

Open
hahnicity opened this issue Apr 22, 2022 · 1 comment
Open

Allow objects to input data into EdfReader #174

hahnicity opened this issue Apr 22, 2022 · 1 comment

Comments

@hahnicity
Copy link

hahnicity commented Apr 22, 2022

Currently working on AWS with EDF objects. Making a feature request to allow some kind of objects similar to StringIO or urllib3.HTTPResponse for input into the EdfReader class instead of a filename. Presumably, this could work using a .read() call on the object. This would save on some IO so that objects wouldn't have to be directly written to local disk before reading and could instead stay remote based.

@hahnicity hahnicity changed the title Allow StreamingBody methods to input data into EdfReader Allow bytes obejcts to input data into EdfReader Apr 22, 2022
@hahnicity hahnicity changed the title Allow bytes obejcts to input data into EdfReader Allow obejcts to input data into EdfReader Apr 22, 2022
@hahnicity hahnicity changed the title Allow obejcts to input data into EdfReader Allow objects to input data into EdfReader Apr 22, 2022
@skjerns
Copy link
Collaborator

skjerns commented Apr 23, 2022

This is probably not so easily possible, as the library we wrap (edflib) is written in C and works with strings that point to files on the file system. Unfortunately we cannot easily pass FILE objects or streams to it, and the last time I tried to implement that I didn't get further (See also #102 and #100). It would probably be possible somehow, but would need some adaptation of the C code to work with streams.

If you feel comfortable enough in C to work on something like this let me know!
Else I have to unfortunately put this on the backend, as I don't have enough time right now do work on this.

@skjerns skjerns closed this as completed Apr 19, 2023
@skjerns skjerns reopened this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants