Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test to be added in hashes exercise already exists in index.ts #49

Open
cumpsty opened this issue Oct 1, 2021 · 3 comments
Open

Test to be added in hashes exercise already exists in index.ts #49

cumpsty opened this issue Oct 1, 2021 · 3 comments

Comments

@cumpsty
Copy link

cumpsty commented Oct 1, 2021

In the documentation for the basic/hashes exercise, I am asked to add a test to index.ts to test for getting a book, but this test already exists in the TS file. This also causes tests to fail for the previous part of the exercise.
@guillemcordoba
Copy link
Contributor

Can you pull again and confirm this is fixed?

@matthabermehl
Copy link
Contributor

Doesn't appear fixed on the main branch, @guillemcordoba.
I logged this issue for the docs: holochain-gym/holochain-gym.github.io#50 where you can see the diffs at a glance. Thanks!

matthabermehl added a commit to matthabermehl/developer-exercises that referenced this issue Dec 3, 2021
@matthabermehl
Fix issue 49
428581f 
holochain-gym#49
Note: This is strictly to bring the file into line with the docs (also see holochain-gym/holochain-gym.github.io#50). The functionality has not been tested.
@matthabermehl matthabermehl mentioned this issue Dec 3, 2021
Merged
@matthabermehl
Copy link
Contributor

PR #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@guillemcordoba @cumpsty @matthabermehl