Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow contributions from forks? #353

Open
maximlt opened this issue Jan 30, 2024 · 3 comments
Open

Allow contributions from forks? #353

maximlt opened this issue Jan 30, 2024 · 3 comments

Comments

@maximlt
Copy link
Contributor

maximlt commented Jan 30, 2024

This repository has a lot of infrastructure to manage the evaluated examples, the deployments, and the websites. These resources need various secrets that are not made available by Github to PRs opened from a fork, for good security reasons. Enabling this would require quite a lot of work, so for now, the optimal workflow is to add contributors as members of the repo with a write role.

Allow contributions from forks:

  • Validate the deployments can be made: need AE5 credentials
    • Maybe this step can be skipped?
  • Push the evaluated notebook to a temporary branch: need write permission
    • Stop using Git as a staging area for evaluated notebooks, e.g. push them on S3.
  • Deploy the dev site: need Personal Access Token
@philippjfr
Copy link
Contributor

Naive question, shouldn't most of the work only be kicked off when the contribution is merged? At which point it will executed within the scope of this repo and have the secrets available?

@maximlt
Copy link
Contributor Author

maximlt commented Jan 30, 2024

It means renouncing building the dev site, doesn't it? I think I didn't go down that route as the former infra had this feature.

@maximlt
Copy link
Contributor Author

maximlt commented Mar 13, 2024

Maybe that could be useful https://github.com/imjohnbo/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants