Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: add a step to validate the content of notebooks #377

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

maximlt
Copy link
Contributor

@maximlt maximlt commented Apr 8, 2024

Precisely, to warn/fail when a notebook contains code outputs when it shouldn't, or doesn't contain any when it should (skip_notebooks_evaluation: True). The goal of this additional validation step is to make it less likely to commit a notebook with code outputs, which is a common gotcha.

cc @jtao1 @Azaya89

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt maximlt merged commit d7ce9c0 into main Apr 8, 2024
7 checks passed
@Azaya89
Copy link
Collaborator

Azaya89 commented Apr 10, 2024

Is there a doit command we should run to activate this step?

@maximlt
Copy link
Contributor Author

maximlt commented Apr 10, 2024

It should run by default when you call doit validate:<project>. It will also run on the CI.

@Azaya89 Azaya89 mentioned this pull request Apr 11, 2024
34 tasks
@maximlt maximlt deleted the infra_warn_evaluated_nb_commit branch October 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants