From f08ca444232b68f76ca59c4abbd41b5222206221 Mon Sep 17 00:00:00 2001
From: farmio <farmio@alphart.net>
Date: Sat, 18 May 2024 14:31:21 +0200
Subject: [PATCH] Test GASelector

---
 .../components/knx/storage/knx_selector.py    |   2 +-
 tests/components/knx/test_knx_selectors.py    | 122 ++++++++++++++++++
 2 files changed, 123 insertions(+), 1 deletion(-)
 create mode 100644 tests/components/knx/test_knx_selectors.py

diff --git a/homeassistant/components/knx/storage/knx_selector.py b/homeassistant/components/knx/storage/knx_selector.py
index c6572db8f6d490..100df4d1acd2d8 100644
--- a/homeassistant/components/knx/storage/knx_selector.py
+++ b/homeassistant/components/knx/storage/knx_selector.py
@@ -75,6 +75,6 @@ def _add_passive(self, schema: dict[vol.Marker, Any]) -> None:
     def _add_dpt(self, schema: dict[vol.Marker, Any]) -> None:
         """Add DPT validator to the schema."""
         if self.dpt is not None:
-            schema[vol.Required("dpt")] = vol.In(self.dpt)
+            schema[vol.Required("dpt")] = vol.In(item.value for item in self.dpt)
         else:
             schema[vol.Remove("dpt")] = object
diff --git a/tests/components/knx/test_knx_selectors.py b/tests/components/knx/test_knx_selectors.py
new file mode 100644
index 00000000000000..432a0fb9f8030d
--- /dev/null
+++ b/tests/components/knx/test_knx_selectors.py
@@ -0,0 +1,122 @@
+"""Test KNX selectors."""
+
+import pytest
+import voluptuous as vol
+
+from homeassistant.components.knx.const import ColorTempModes
+from homeassistant.components.knx.storage.knx_selector import GASelector
+
+INVALID = "invalid"
+
+
+@pytest.mark.parametrize(
+    ("selector_config", "data", "expected"),
+    [
+        (
+            {},
+            {},
+            {"write": None, "state": None, "passive": []},
+        ),
+        (
+            {},
+            {"write": "1/2/3"},
+            {"write": "1/2/3", "state": None, "passive": []},
+        ),
+        (
+            {},
+            {"state": "1/2/3"},
+            {"write": None, "state": "1/2/3", "passive": []},
+        ),
+        (
+            {},
+            {"passive": ["1/2/3"]},
+            {"write": None, "state": None, "passive": ["1/2/3"]},
+        ),
+        (
+            {},
+            {"write": "1", "state": 2, "passive": ["1/2/3"]},
+            {"write": "1", "state": 2, "passive": ["1/2/3"]},
+        ),
+        (
+            {"write": False},
+            {"write": "1/2/3"},
+            {"state": None, "passive": []},
+        ),
+        (
+            {"write": False},
+            {"state": "1/2/3"},
+            {"state": "1/2/3", "passive": []},
+        ),
+        (
+            {"write": False},
+            {"passive": ["1/2/3"]},
+            {"state": None, "passive": ["1/2/3"]},
+        ),
+        (
+            {"passive": False},
+            {"passive": ["1/2/3"]},
+            {"write": None, "state": None},
+        ),
+        (
+            {"passive": False},
+            {"write": "1/2/3"},
+            {"write": "1/2/3", "state": None},
+        ),
+        # required keys
+        (
+            {"write_required": True},
+            {},
+            INVALID,
+        ),
+        (
+            {"state_required": True},
+            {},
+            INVALID,
+        ),
+        (
+            {"write_required": True},
+            {"write": "1/2/3"},
+            {"write": "1/2/3", "state": None, "passive": []},
+        ),
+        (
+            {"state_required": True},
+            {"state": "1/2/3"},
+            {"write": None, "state": "1/2/3", "passive": []},
+        ),
+        (
+            {"write_required": True},
+            {"state": "1/2/3"},
+            INVALID,
+        ),
+        (
+            {"state_required": True},
+            {"write": "1/2/3"},
+            INVALID,
+        ),
+        # dpt key
+        (
+            {"dpt": ColorTempModes},
+            {"write": "1/2/3"},
+            INVALID,
+        ),
+        (
+            {"dpt": ColorTempModes},
+            {"write": "1/2/3", "dpt": "7.600"},
+            {"write": "1/2/3", "state": None, "passive": [], "dpt": "7.600"},
+        ),
+        (
+            {"dpt": ColorTempModes},
+            {"write": "1/2/3", "state": None, "passive": [], "dpt": "invalid"},
+            INVALID,
+        ),
+    ],
+)
+def test_ga_selector(selector_config, data, expected):
+    """Test GASelector."""
+    selector = GASelector(**selector_config)
+    if expected == INVALID:
+        with pytest.raises(vol.Invalid):
+            selector(data)
+    else:
+        result = selector(data)
+        assert result == expected