Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken expando for domain i.redgifs.com (NSFW) #5468

Open
NotJBT opened this issue May 10, 2023 · 2 comments · May be fixed by #5481
Open

Broken expando for domain i.redgifs.com (NSFW) #5468

NotJBT opened this issue May 10, 2023 · 2 comments · May be fixed by #5481

Comments

@NotJBT
Copy link

NotJBT commented May 10, 2023

What's the problem?
The expando for https://old.reddit.com/domain/i.redgifs.com/ is broken. Error below pops up in chrome debug stuff any time you try to use the expando. It does it with redgifs expando turned on or off for #res:settings/showImages/display_redgifs
oss-Origin Read Blocking (CORB) blocked cross-origin response https://www.redgifs.com/watch/crazypalegreenbaiji with MIME type text/html. See https://www.chromestatus.com/feature/5629709824032768 for more details.
Image (async)
string_html @ chrome-extension://k…round.entry.js:4188
imageTemplate @ chrome-extension://k…ound.entry.js:10705
showImages_Image @ chrome-extension://k…ound.entry.js:15561
generateMedia @ chrome-extension://k…ound.entry.js:15090
generateMedia @ chrome-extension://k…ound.entry.js:14964
(anonymous) @ chrome-extension://k…ound.entry.js:15076
forEachSeq @ chrome-extension://k…round.entry.js:1422
preloadMedia @ chrome-extension://k…ound.entry.js:15073
(anonymous) @ chrome-extension://k…ound.entry.js:15003

This error doesn't pop up until clicking the button to open the expando. It does it with all of my other extensions turned off and Shift+F5 ing.

Are there any related posts in https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues or /r/RESissues?
https://old.reddit.com/r/RESissues/comments/138ah4d/redgifs_images_not_loading_properly_in_res/

What other browser extensions are installed?
BetterTTV
Google Docs Offline
Imagus
Reddit Deduplicator
simple-modify-headers
uBlock Origin

@0x0054
Copy link

0x0054 commented Aug 14, 2023

I may have an idea on how to fix this but don't have the necessary know-how or the time to get into contributing to the extension at the moment.

If you want a quick and dirty fix for this do the following:

  • Go to the extension folder, depending on your OS and Browser it should look something like:
    C:\Users\USERNAME\AppData\Local\Google\Chrome\User Data\Default\Extensions\kbmfpngjjgdllneeigpgjifpgocmfgmb\5.22.17_0
  • Find the file foreground.entry.js
  • Search for "redgifs", it should bring you to the line starting with /* harmony default export */ var redgifs = (new Host('redgifs', {
  • From there go down a few lines (for me it was line number 12893) to the regex: /^\/(?:(?:ifr|watch)\/)(\w+)/i
  • Add the following after the word watch: |i so that it looks like this: /^\/(?:(?:ifr|watch|i)\/)(\w+)/i
  • Save the file and reload the extension (I did this by disabling and then enabling the extension, though I don't know if that even makes a difference tbh)

This should work, I think (at least it does for me), until RES updates again.

@NotJBT
Copy link
Author

NotJBT commented Aug 14, 2023 via email

@yereter yereter linked a pull request Oct 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants