Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve test failures caused by new Sinatra behavior #243

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

robbkidd
Copy link
Member

@robbkidd robbkidd commented Dec 2, 2024

Which problem is this PR solving?

Short description of the changes

  • Update the test Sinatra server to allow anybody to talk to it.

## Which problem is this PR solving?

- [Sinatra 4.1.0 introduced a host authorization option to Sinatra apps](sinatra/sinatra#2053). That authorization check was failing requests made in tests.

## Short description of the changes

-  Update the test Sinatra server to allow anybody to talk to it.

Co-authored-by: Tyler Helmuth <[email protected]>
@robbkidd robbkidd added version: no bump A PR with maintenance or doc changes that aren't included in a release. no-changelog Omit this PR from changelog/release notes. labels Dec 2, 2024
@robbkidd robbkidd requested a review from a team as a code owner December 2, 2024 22:14
Redundant curly braces around a hash parameter.
@robbkidd robbkidd merged commit 67a9922 into main Dec 2, 2024
5 checks passed
@robbkidd robbkidd deleted the tybb.fix-sinatra-in-tests branch December 2, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Omit this PR from changelog/release notes. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants