feat(kafka-receiver): add flags/configs for kafka receiving #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizthegrey
force-pushed
the
lizf.kafka
branch
from
f3fcdb6
to
3fd0e47
Compare
kentquirk
reviewed
Feb 1, 2024
config.md
Outdated
| @@ -136,6 +136,39 @@ This is the amount of time after which if the http server does not see any activ | |||
| - Type: `duration` | |||
| - Default: `0s` | |||
|
|
|||
| ### `KafkaBootstrapAddr` | |||
There was a problem hiding this comment.
I'd like to see this moved out to its own group rather than just being in the network configuration, and I'd also give it its own config type. If you call the group "Kafka" you can remove that prefix from all of its names; I think you'll probably want an Enabled flag on it as well.
Then, you could consider having a single accessor that returns the entire group, or leave the separate ones.
lizthegrey
force-pushed
the
lizf.kafka
branch
from
3fd0e47
to
0cfc24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes