Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is hello_controller.js necessary during install? #146

Closed
joshuay03 opened this issue Oct 2, 2024 · 2 comments · May be fixed by #147
Closed

Is hello_controller.js necessary during install? #146

joshuay03 opened this issue Oct 2, 2024 · 2 comments · May be fixed by #147

Comments

@joshuay03
Copy link

joshuay03 commented Oct 2, 2024

When creating a new rails app with the default setup, stimulus:install adds a dummy hello_controller.js here, which in my experience eventually just ends up getting deleted since it isn't referenced in any of the new app's view templates for demoing purposes.

Seeing as the turbo:install step doesn't create any dummy controllers and view templates that utilize frames, streams etc., nor any stimulus, and it's up to the user to read the handbook and figure it out for themselves, can we assume the same for stimulus controllers and drop this file? The controller is pretty basic anyway and not really a preview of all the available stimulus APIs.

I'm happy to get a PR up to remove it if needed.

@dhh
Copy link
Member

dhh commented Oct 5, 2024

Yeah, we can delete it. Do a PR 👍

@joshuay03
Copy link
Author

#147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants