Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please can you create example ? #100

Open
Khalidalansi opened this issue Oct 3, 2018 · 20 comments
Open

please can you create example ? #100

Khalidalansi opened this issue Oct 3, 2018 · 20 comments

Comments

@Khalidalansi
Copy link

Khalidalansi commented Oct 3, 2018

please can you create example ?

@alfonsosn
Copy link

Agreed, I've tried using this library in the past with iOS and the setup never works.

@edzh1
Copy link

edzh1 commented Oct 7, 2018

@Khalidalansi @alfonsosn Hi. I can provide a gist with example. What do you need exactly?

@Khalidalansi
Copy link
Author

@edzh1 Thank you for your reply. I would like to integrate these capabilities into a React Native app:

  1. Receive calls through the app itself; not have to ring person’s actual number
  2. Make calls through the app itself
  3. Make and receive texts in app
  4. Record all calls and show list of recent calls in app

@edzh1
Copy link

edzh1 commented Oct 7, 2018

@Khalidalansi I understood you, thanks. @fabriziomoscon Won't you mind if I'll create a pull request with an example?

@Khalidalansi
Copy link
Author

@edzh1 Yes, that will be great! I am looking forward to it.

@edzh1
Copy link

edzh1 commented Oct 7, 2018

@Khalidalansi Please, give me a couple days to create an example app and medium article with an explanation. I'll notify you when it'll be done

@Khalidalansi
Copy link
Author

@edzh1 Thank you!!

@fabriziomoscon
Copy link
Collaborator

In principle I second the idea, but in my experience the example apps I saw in other libraries in the past are constantly out of date. And the reason is that authors are always in short of time and react-native evolves very quickly.

I currently don't have capacity for an example app. Honestly I will not have capacity to keep it updated with the latest ever improving react native and Google libraries.
If you have capacity for an example app please include a complete explanation on which compatibility libraries are used, so that the user are aware when is out of date.

Thanks!

@edzh1
Copy link

edzh1 commented Oct 13, 2018

@Khalidalansi @alfonsosn https://medium.com/@edzh1/create-a-twilio-voip-calls-in-a-react-native-app-35a729a9613d

@alfonsosn
Copy link

@edzh1 I'll be working on integrating the library in the following days, but thank you so much for this super helpful guide, really clarified things for me. LEGEND!

@edzh1
Copy link

edzh1 commented Oct 15, 2018

@edzh1 I'll be working on integrating the library in the following days, but thank you so much for this super helpful guide, really clarified things for me. LEGEND!

Glad I could help :)

@marcelocbf
Copy link

marcelocbf commented Nov 24, 2018

@Khalidalansi @alfonsosn https://medium.com/@edzh1/create-a-twilio-voip-calls-in-a-react-native-app-35a729a9613d

Wouldn't be able to integrate the library without it. Should be on the README. Thank you so much! @edzh1

@gentleShark
Copy link

@edzh1 @fabriziomoscon does anyone have an example of how to accept a call on Android? presumably on iOS this is handled by CallKit? I can get my emulator to ring but I'm looking for a way to capture the event and present the user with the option to accept or reject the call

@jdegger
Copy link
Collaborator

jdegger commented Oct 27, 2020

In the next couple of months we will be trying to improve the docs and add examples. If somebody is willing to help, read our update here on how to contribute #158

@morpheis91
Copy link

morpheis91 commented Oct 30, 2020

Please if you could expedite this or have an ongoing one as PRs get merged. Do you know if this example is still valid?
https://medium.com/@edzh1/create-a-twilio-voip-calls-in-a-react-native-app-35a729a9613d

@jdegger
Copy link
Collaborator

jdegger commented Oct 31, 2020

@morpheis91 that articile seems to be outdated. Since it was written, we have changed a lot in the library. Especially version 4 which was just released. So far nobody is actively working on the example app but we will need it in the near future.

@edzh1
Copy link

edzh1 commented Nov 3, 2020

@jdegger I can update my article and create new example app

@jdegger
Copy link
Collaborator

jdegger commented Nov 3, 2020

@edzh1 that would be wonderful. Would you be interested in authoring the example app and publishing it on the hoxfon org so we can maintain it here and use for testing as well? In #158 I also explain that we are looking for somebody to help us with setting up a proper example

@edzh1
Copy link

edzh1 commented Nov 3, 2020

@jdegger sure, will start working on that

@danstepanov
Copy link

@edzh1 Did you ever end up finishing the example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants