Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotations, affinity, nodeselector, tolerations support #54

Open
knackaron opened this issue Sep 30, 2019 · 1 comment
Open

add annotations, affinity, nodeselector, tolerations support #54

knackaron opened this issue Sep 30, 2019 · 1 comment

Comments

@knackaron
Copy link
Contributor

This is specific to the hpe-csi-driver chart. We should be able to define annotations, affinity, nodeSelector, and tolerations for the deployments. These are standard Helm chart features and permit an operator to tailor the deployment to their cluster(s). Specifically, I need to be able to add a toleration for tainted masters to be able to run the node driver. It would be preferable to run the controller on only masters as well. Adding support for these fields would allow an operator to accomplish both of these needs.

The chart values currently don't have much structure, so I wanted to discuss before submitting a PR. The additional values I outlined would need to be configurable for each deployment in the chart, as they could be unique for hpe-csi-controller and hpe-csi-node for example.

@shivamerla
Copy link
Collaborator

@knackaron Thanks for your valuable inputs. Please file a PR with your suggestions. We are inclined towards these changes as well.

wombat added a commit to WombatSoftware/co-deployments that referenced this issue Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants