Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can't just compare version strings like this #87

Open
VortexUK opened this issue Mar 23, 2022 · 2 comments
Open

You can't just compare version strings like this #87

VortexUK opened this issue Mar 23, 2022 · 2 comments

Comments

@VortexUK
Copy link

current_wsapi_version = '{}.{}.{}'.format(api_version.get('major'),
api_version.get('minor'),
api_version.get('revision'))
if current_wsapi_version >= self.WSAPI_MIN_VERSION_COMPRESSION_SUPPORT:

The WSAPI version on primera is now 1.10.0. Which since the 'minimum' version is 1.5.0, means that the code thinks the minimum version is not met and breaks any attempt at a creation of a compressed lun. Please fix ASAP

@VortexUK
Copy link
Author

VortexUK commented Mar 23, 2022

Just to give the simplest example possible:

>>> WSAPI_MIN_SUPPORTED_VERSION = '1.5.0'
>>> before = '1.9.0'
>>> after = '1.10.0'
>>> before >= WSAPI_MIN_SUPPORTED_VERSION
True
>>> after >= WSAPI_MIN_SUPPORTED_VERSION
False

@VortexUK
Copy link
Author

In the SDK, you compare them correctly using StrictVersion, so the same thing applies here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant