Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2304 Increase OAuth2 login timeout #1037

Closed
wants to merge 1 commit into from
Closed

N21-2304 Increase OAuth2 login timeout #1037

wants to merge 1 commit into from

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Nov 26, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

This was referenced Nov 26, 2024
Closed
Closed
mamutmk5
mamutmk5 requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@mamutmk5 mamutmk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very bad Idee to add this Timeout and set it to 20 Seconds so that bad code is execude.
Execution time shoud and must be lower then 3 seconds and for the best lower then 500ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamutmk5 mamutmk5 mamutmk5 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @mamutmk5