From ca3460213439bc3e476651f40bcb4584824b804d Mon Sep 17 00:00:00 2001
From: Mani Ka <mani@talview.com>
Date: Sun, 16 May 2021 17:51:23 -0700
Subject: [PATCH] Updates ImagePullPolicy to ifNotPresent

Images are referenced by specific build/release tags.
Always pulling hits docker hub free limits for unauthenticated calls [1] on few redeployments

This improves performance of deploy and keeps reducer Docker Hub calls to help keep within limit

[1] https://docs.docker.com/docker-hub/download-rate-limit/#how-do-i-authenticate-pull-requests
---
 base/jitsi-shard/jicofo-deployment.yaml                 | 2 +-
 base/jitsi-shard/jvb/jvb-statefulset.yaml               | 4 ++--
 base/jitsi-shard/prosody-deployment.yaml                | 2 +-
 base/jitsi-shard/web-deployment.yaml                    | 2 +-
 base/ops/dashboard/kubernetes-dashboard.yaml            | 2 +-
 base/ops/metacontroller/service-per-pod-deployment.yaml | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/base/jitsi-shard/jicofo-deployment.yaml b/base/jitsi-shard/jicofo-deployment.yaml
index 84985bc..6429c00 100644
--- a/base/jitsi-shard/jicofo-deployment.yaml
+++ b/base/jitsi-shard/jicofo-deployment.yaml
@@ -30,7 +30,7 @@ spec:
               memory: 400Mi
               cpu: 400m
           image: jitsi/jicofo:stable-4548-1
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           readinessProbe:
             # caution: this readinessProbe tries to create a new conference and hence also fails if
             # dependencies (jvb, prosody) are not available
diff --git a/base/jitsi-shard/jvb/jvb-statefulset.yaml b/base/jitsi-shard/jvb/jvb-statefulset.yaml
index a31cc73..42a4263 100644
--- a/base/jitsi-shard/jvb/jvb-statefulset.yaml
+++ b/base/jitsi-shard/jvb/jvb-statefulset.yaml
@@ -39,7 +39,7 @@ spec:
           # sidecar container that exports stats for prometheus
           # values are scraped by ../ops/monitoring/jvb-pod-monitor.yaml
           image: systemli/prometheus-jitsi-meet-exporter:1.1.1
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - name: metrics
               containerPort: 9888
@@ -48,7 +48,7 @@ spec:
             - "http://localhost:8080/colibri/stats"
         - name: jvb
           image: jitsi/jvb:stable-4548-1
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           lifecycle:
             preStop:
               exec:
diff --git a/base/jitsi-shard/prosody-deployment.yaml b/base/jitsi-shard/prosody-deployment.yaml
index 37416d8..0be291f 100644
--- a/base/jitsi-shard/prosody-deployment.yaml
+++ b/base/jitsi-shard/prosody-deployment.yaml
@@ -45,7 +45,7 @@ spec:
               memory: 300Mi
               cpu: 300m
           image: jitsi/prosody:stable-4548-1
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - name: metrics
               containerPort: 5280
diff --git a/base/jitsi-shard/web-deployment.yaml b/base/jitsi-shard/web-deployment.yaml
index f5e620d..300b4e1 100644
--- a/base/jitsi-shard/web-deployment.yaml
+++ b/base/jitsi-shard/web-deployment.yaml
@@ -43,7 +43,7 @@ spec:
               memory: 300Mi
               cpu: 400m
           image: jitsi/web:stable-4548-1
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           readinessProbe:
             httpGet:
               port: 80
diff --git a/base/ops/dashboard/kubernetes-dashboard.yaml b/base/ops/dashboard/kubernetes-dashboard.yaml
index 3ca9d94..3a8331a 100644
--- a/base/ops/dashboard/kubernetes-dashboard.yaml
+++ b/base/ops/dashboard/kubernetes-dashboard.yaml
@@ -190,7 +190,7 @@ spec:
       containers:
         - name: kubernetes-dashboard
           image: kubernetesui/dashboard:v2.0.0
-          imagePullPolicy: Always
+          imagePullPolicy: IfNotPresent
           ports:
             - containerPort: 8443
               protocol: TCP
diff --git a/base/ops/metacontroller/service-per-pod-deployment.yaml b/base/ops/metacontroller/service-per-pod-deployment.yaml
index 81bd9b9..3c17ed8 100644
--- a/base/ops/metacontroller/service-per-pod-deployment.yaml
+++ b/base/ops/metacontroller/service-per-pod-deployment.yaml
@@ -16,7 +16,7 @@ spec:
       containers:
       - name: hooks
         image: metacontroller/jsonnetd:0.1
-        imagePullPolicy: Always
+        imagePullPolicy: IfNotPresent
         workingDir: /hooks
         volumeMounts:
         - name: hooks