Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow crypton-connection 0.4. #109

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

alaendle
Copy link
Contributor

@alaendle alaendle commented Jun 3, 2024

Something for a new v0.23 of amqp.

@hreinhardt hreinhardt merged commit 660a59a into hreinhardt:master Jun 3, 2024
8 checks passed
@hreinhardt
Copy link
Owner

Thanks. I'm a little rusty on the package versioning policies, but couldn't it be 0.22.3?

@alaendle
Copy link
Contributor Author

alaendle commented Jun 3, 2024

@hreinhardt Since I lifted the lower bound of crypton-connection I believe this is a "transparent" breaking change - so my interpretation of the PVP is that with this change in place amqp should move to 0.23. Or to put it the other way around, a minor version update (0.22.3) would indicate that existing code (maybe targeting amqp 0.22.2 and crypton-connection 0.3) could be build without changes - which is not the case.

@hreinhardt
Copy link
Owner

OK, I decided to play it safe and pick 0.23.0. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants