Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor order structures #111

Merged
merged 9 commits into from
Sep 18, 2023
Merged

Refactor order structures #111

merged 9 commits into from
Sep 18, 2023

Conversation

lumos42
Copy link

@lumos42 lumos42 commented Sep 15, 2023

Why this should be merged

Refactors order structure in memory database.

@atvanguard atvanguard self-requested a review September 17, 2023 04:03
Copy link

@atvanguard atvanguard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sortLongOrders and sortShortOrders are unused so code can be deleted.

plugin/evm/orderbook/memory_database.go Outdated Show resolved Hide resolved
plugin/evm/orderbook/memory_database.go Outdated Show resolved Hide resolved
plugin/evm/orderbook/memory_database.go Outdated Show resolved Hide resolved
plugin/evm/orderbook/memory_database.go Outdated Show resolved Hide resolved
plugin/evm/orderbook/memory_database.go Outdated Show resolved Hide resolved
@atvanguard atvanguard merged commit 69cf672 into main Sep 18, 2023
2 checks passed
@atvanguard atvanguard deleted the order_refactor branch September 18, 2023 05:58
atvanguard added a commit that referenced this pull request Sep 30, 2023
* Refactor order structures

* Fix tests and add new test

* update old order type

* Review fixes

* Review fixes

* Review fix

* Handle idx = -1

* Unit tests for Delete

---------

Co-authored-by: atvanguard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants