Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting typo in model architectures list in chapter2/2.mdx #559

Open
MrGeislinger opened this issue May 3, 2023 · 2 comments · May be fixed by #560
Open

Formatting typo in model architectures list in chapter2/2.mdx #559

MrGeislinger opened this issue May 3, 2023 · 2 comments · May be fixed by #560

Comments

@MrGeislinger
Copy link

In Chapter 2's "Model heads: Making sense out of numbers" section a non-exhaustive list of model architectures are listed, but the formatting seems to have included additional unnecessary *:

- `*Model` (retrieve the hidden states)
- `*ForCausalLM`
- `*ForMaskedLM`
- `*ForMultipleChoice`
- `*ForQuestionAnswering`
- `*ForSequenceClassification`
- `*ForTokenClassification`
- and others 🤗

Reference to specific lines: 2.mdx#L225-L231
@MrGeislinger
Copy link
Author

This seems to maybe be in other translations too. Here is the same typo in the French translation: https://github.com/huggingface/course/blame/main/chapters/fr/chapter2/2.mdx#L198-L204

MrGeislinger added a commit to MrGeislinger/course that referenced this issue May 3, 2023
@MrGeislinger
Remove excess * in model architecture list
e82001f 
- Fixes huggingface#559 (English version only)
MrGeislinger added a commit to MrGeislinger/course that referenced this issue May 3, 2023
@MrGeislinger
Remove * in architecture list (all languages)
5288be3 
- Fixes huggingface#559 for all languages
@MrGeislinger MrGeislinger linked a pull request May 3, 2023 that will close this issue
Open
@MKhalusova
Copy link
Contributor

Please see #560 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chapter 2's 2.mdx format typo for model architectures MrGeislinger/course
2 participants
@MKhalusova @MrGeislinger