Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor language error in Chapter 2, Tokenizers, sub-heading Character-based #599

Open
dntrply opened this issue Aug 7, 2023 · 1 comment

Comments

@dntrply
Copy link

dntrply commented Aug 7, 2023

The comment
"This approach isn’t perfect either. Since the representation is now based on characters rather than words, one could argue that, intuitively, it’s less meaningful: each character doesn’t mean a lot on its own, whereas that is the case with words. "

should likely read
"This approach isn’t perfect either. Since the representation is now based on characters rather than words, one could argue that, intuitively, it’s less meaningful: each character doesn’t mean a lot on its own, whereas that is not the case with words. "

I am assuming the implication when saying " whereas that is the case with words." is that each word means a lot on it's own. However, when put in the context of the prior (negative) assertion "each character doesn’t mean a lot on its own", it seems the appropriate follow up ought to be that it is not the case with words (that "each character doesn’t mean a lot on its own")

@dntrply
Copy link
Author

dntrply commented Aug 9, 2023

Having reread the para in questions, and paying more attention to the : after meaningful, the two parts

each character doesn’t mean a lot on its own,
and,
whereas that is the case with words.

make sense as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant