Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small mistake in Chap6: BPE tokenization #608

Open
martianmartina opened this issue Aug 29, 2023 · 0 comments
Open

A small mistake in Chap6: BPE tokenization #608

martianmartina opened this issue Aug 29, 2023 · 0 comments

Comments

@martianmartina
Copy link

image
There might be a small issue: in the example "thug", the given merge rules will first result in "u" and "g" being merged, but then it should be "h" and "ug", instead of "hu" and "g".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martianmartina