Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlNet Reference Only for SD XL #4675

Closed
jelling opened this issue Aug 18, 2023 · 15 comments · May be fixed by #9893
Closed

ControlNet Reference Only for SD XL #4675

jelling opened this issue Aug 18, 2023 · 15 comments · May be fixed by #9893
Labels
stale Issues that haven't received updates

Comments

@jelling
Copy link

jelling commented Aug 18, 2023

Is your feature request related to a problem? Please describe.

There is currently a Diffusers example for using "Reference Only" with ControlNet. But there is not yet one for XL.

Describe the solution you'd like

It would be great to have an example for SD XL.

Please and thanks!

@sayakpaul
Copy link
Member

Feel free to add a PR :)

@jelling
Copy link
Author

jelling commented Aug 21, 2023

Yeah, I may do that. Before I dive in, are there any known reasons why reference only wouldn't work with the XL controlnet?

(What I'm working around is that because textual inversions aren't supported yet for XL - thank you for your help with understanding that btw - I now need a new solution for a problem that I was previously solving with TIs.)

@sayakpaul
Copy link
Member

The ControlNet accepts additional embeddings for SDXL. Maybe that needs to be rejigged.

@github-actions github-actions bot added the stale Issues that haven't received updates label Oct 18, 2023
@patrickvonplaten patrickvonplaten removed the stale Issues that haven't received updates label Oct 18, 2023
@huggingface huggingface deleted a comment from github-actions bot Oct 18, 2023
@charlesmccarthy
Copy link

any updates on this?

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Nov 23, 2023
@reimager
Copy link
Contributor

Commenting so this isn't stale. Still following this issue. This pipeline would be really useful.

@sayakpaul sayakpaul removed the stale Issues that haven't received updates label Nov 27, 2023
@sayakpaul
Copy link
Member

Welcome to PRs.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 26, 2023
@DN6
Copy link
Collaborator

DN6 commented Dec 27, 2023

PRs are welcome for this addition. But I'm just curious to understand why IP adapters wouldn't be able to provide similar functionality?

@reimager
Copy link
Contributor

PRs are welcome for this addition. But I'm just curious to understand why IP adapters wouldn't be able to provide similar functionality?

I originally struggled to get good results with the ip_adapter, but I was using another implementation. I have since tried the current one in diffusers with load_ip_adapter and it does seem to work great and basically has the same effect as reference-only so maybe this is obsolete.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this as completed Feb 4, 2024
@shabri-arrahim
Copy link

Need this too

@Adenialzz
Copy link
Contributor

need this

@Adenialzz
Copy link
Contributor

PRs are welcome for this addition. But I'm just curious to understand why IP adapters wouldn't be able to provide similar functionality?

IP-Adapter use CLIP image encoder to produce semantic image features which may be lack of detailed texture features. While dense features from reference only controlnet will work better in specific situations.

@asomoza
Copy link
Member

asomoza commented May 24, 2024

Can someone post an example for this? I mean the reference image, the prompt and the result, so I can compare it and if indeed it's better than IP Adapters, add it to my to-do list if no one from the community wants to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants