-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lora_conversion_utils.py #9980
base: main
Are you sure you want to change the base?
Conversation
x-flux single-blocks lora load
@raulmosa could you give this a look? |
I've checked it and it's right, it shouldn't be norm. Looks good to me @sayakpaul . |
@zhaowendao30 thanks for your contribnutions! Could you also do a side-by-side comparison of your changes applied and without your changes in the outputs? That would be very much appreciated. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
No thanks =) |
OK, the single block i just trained index 1,2,3,4, and the first image is load in qkv, the second is load in norm, the last is no lora |
@zhaowendao30 thanks, but please prefer not using human subjects in the public forums. I will run the tests today and update the slices as needed because of the change. |
OK, I've uploaded it again. However, this is a LoRA about people, and the panda looks a bit strange. =) |
Just ran
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
x-flux single-blocks lora load
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.