Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for packing tokenized datasets #2011

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kmehant
Copy link

@kmehant kmehant commented Sep 3, 2024

What does this PR do?

Fixes #1848

Before submitting

Who can review?

@qgallouedec

Anyone from the community!

@kmehant kmehant changed the title feat: add support for packing tokenized datasetS feat: add support for packing tokenized datasets Sep 3, 2024
@kmehant
Copy link
Author

kmehant commented Sep 22, 2024

Anyone having bandwidth, requesting review thank you - @qgallouedec @lewtun @kashif @lvwerra or others from community.

Discussion can be seen here - #1848

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @kmehant ! Overall it looks good to me - would you mind adding an integration test for this scenario?

trl/trainer/sft_trainer.py Outdated Show resolved Hide resolved
trl/trainer/utils.py Outdated Show resolved Hide resolved
trl/trainer/utils.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kmehant
Copy link
Author

kmehant commented Oct 2, 2024

@lewtun Thank you for your review. I have addressed the review comments and as well added the test cases. Thank you.

@kmehant kmehant requested a review from lewtun October 2, 2024 06:38
@kmehant kmehant force-pushed the pack-pretok branch 3 times, most recently from 1f9ee11 to 0d0f34c Compare October 8, 2024 03:54
@kmehant
Copy link
Author

kmehant commented Oct 8, 2024

@lewtun @qgallouedec requesting review and escalation, thank you.

@kmehant kmehant force-pushed the pack-pretok branch 2 times, most recently from c689f24 to 817c933 Compare October 10, 2024 05:09
@kmehant kmehant force-pushed the pack-pretok branch 2 times, most recently from 95113ee to 25b997d Compare October 24, 2024 04:23
@kmehant
Copy link
Author

kmehant commented Oct 24, 2024

Screenshot 2024-10-24 at 10 14 30 AM

@lewtun @qgallouedec apologies for the failing tests before. Tests passing now for me locally! Thank you.

@kmehant
Copy link
Author

kmehant commented Oct 29, 2024

@lewtun @qgallouedec rebased looking for escalation, thanks.

@kmehant
Copy link
Author

kmehant commented Nov 4, 2024

@lewtun @qgallouedec Related tests pass after rebase, looking forward to including this work soon! Appreciate it.

@kmehant
Copy link
Author

kmehant commented Nov 12, 2024

@lewtun @qgallouedec pulse pinging for review and merge, thank you.

@kmehant
Copy link
Author

kmehant commented Nov 20, 2024

@lewtun @qgallouedec any updates on this would be helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support packing for pretokenized datasets
3 participants