Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VAS to TRL #2195

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add VAS to TRL #2195

wants to merge 17 commits into from

Conversation

idanshen
Copy link
Contributor

@idanshen idanshen commented Oct 7, 2024

This PR introduces the implementation of Value Augmented Sampling (VAS), based on the paper Value Augmented Sampling for Language Model Alignment and Personalization. VAS enhances language model generation by incorporating a value function that guides the decoding process.

Key Components:

  • VASTrainer: Implements the training algorithm for the Value function.
  • VASSampler: Implements the generation process according to the VAS decoding scheme. Uses the trained Value function to adjust the sampling probabilities during inference.

@kashif kashif added the ✨ enhancement New feature or request label Oct 8, 2024
@idanshen
Copy link
Contributor Author

idanshen commented Nov 7, 2024

Hi! Just wanted to check in—I'm here if you have any questions or need any clarification on the PR.

trl/__init__.py Outdated Show resolved Hide resolved
trl/__init__.py Outdated Show resolved Hide resolved
@kashif
Copy link
Collaborator

kashif commented Nov 7, 2024

@idanshen so would you mind adding a test as well for the trainer?

@kashif
Copy link
Collaborator

kashif commented Nov 7, 2024

@idanshen also documentation would be awesome as well as some results if you have to share?

@idanshen
Copy link
Contributor Author

Few changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants