[GKD] add ULD type loss to GKD Trainer #2263
Open
+268
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qgallouedec
reviewed
Oct 24, 2024
Co-authored-by: Quentin Gallouédec <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Nov 23, 2024
| with torch.no_grad(): | ||
| outputs_teacher = self.teacher_model( | ||
| input_ids=inputs["input_ids"], |
There was a problem hiding this comment.
Why do you use a different input ids here?
|
Looks good overall. Feel free to request a final review from me when you think it's ready to be merged |
qgallouedec
reviewed
Nov 23, 2024
| @@ -42,6 +42,21 @@ | |||
| --use_peft \ | |||
| --lora_r 64 \ | |||
| --lora_alpha 16 | |||
|
|
|||
| # ULD | |||
| python examples/scripts/gkd.py \ | |||
There was a problem hiding this comment.
Where is the argument related to ULD?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ULD loss to GKD trainer that doesn't require the student/teacher to have the same vocab by optimal transporting the prob from the teacher to student