-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support enforcing line breaks after "end of sentence" #222
Comments
Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗 |
Thanks for the issue! Please have a look at #4. This seems like a duplicate? Extracting sentences from text is not an easy task (especially given other languages besides English) so my most recent thoughts are that this should perhaps be researched in a plugin to see if it works. One can not simply break lines after a punctuation char (e.g. "Temple of Doom was discovered by Dr. Jones." will be wrapped incorrectly). Also, inline code and emphasis blocks located mid sentence add some challenge. |
Ah indeed I think it's a duplicate based on content. I didn't think to look into that issue after looking at the title because it didn't mention sentence-based line breaks in the title Also agree w/ all of your points! |
Cool, and I agree that the issue title was pretty bad 😄 Fixed that, thanks. |
It would be useful if we could use a feature flag to enforce "one sentence per line". This basically means following the first 4 rules of the "semantic line breaks" spec (and most importantly, following all of the
MUST
rules).I've found this to give much of the "benefits of sembr" without much extra work.
The text was updated successfully, but these errors were encountered: