Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enforcing line breaks after "end of sentence" #222

Closed
choldgraf opened this issue Jun 9, 2021 · 4 comments
Closed

Support enforcing line breaks after "end of sentence" #222

choldgraf opened this issue Jun 9, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link

It would be useful if we could use a feature flag to enforce "one sentence per line". This basically means following the first 4 rules of the "semantic line breaks" spec (and most importantly, following all of the MUST rules).

I've found this to give much of the "benefits of sembr" without much extra work.

@choldgraf choldgraf added the enhancement New feature or request label Jun 9, 2021
@welcome
Copy link

welcome bot commented Jun 9, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@hukkin
Copy link
Owner

hukkin commented Jun 9, 2021

Thanks for the issue!

Please have a look at #4. This seems like a duplicate?

Extracting sentences from text is not an easy task (especially given other languages besides English) so my most recent thoughts are that this should perhaps be researched in a plugin to see if it works. One can not simply break lines after a punctuation char (e.g. "Temple of Doom was discovered by Dr. Jones." will be wrapped incorrectly).

Also, inline code and emphasis blocks located mid sentence add some challenge.

@choldgraf
Copy link
Author

choldgraf commented Jun 9, 2021

Ah indeed I think it's a duplicate based on content. I didn't think to look into that issue after looking at the title because it didn't mention sentence-based line breaks in the title

Also agree w/ all of your points!

@hukkin
Copy link
Owner

hukkin commented Jun 9, 2021

Cool, and I agree that the issue title was pretty bad 😄 Fixed that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants