-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image path is falsely patched with <>
if URL includes ()
, breaks render
#416
Comments
seems the problem is |
<>
if URL includes ()
, breaks render
Thanks for the issue!
This seems to me like a renderer issue. Which renderer do you use? If I copy the link (with angle brackets) to e.g. GitHub's or Gitlab's comment field and press the "Preview" button, both correctly render the image. The angle brackets should be allowed here. |
GitHub preview I guess and maybe PyPI... |
I can confirm the issue with the latest version:
# Edge case
[Split screen](https://en.wikipedia.org/wiki/Split_screen_(video_production))
# Edge case
[Split screen](<https://en.wikipedia.org/wiki/Split_screen_(video_production)>) Instead, I would expect # Edge case
[Split screen](https://en.wikipedia.org/wiki/Split_screen_%28video_production%29) |
This isn't really a bug though, except in @Borda's CommonMark renderer. According to spec the link should render the same with the angle brackets. @kdeldycke what do you use to render? As I showed in #416 (comment), GitHub renders this just fine. Here's the spec: https://spec.commonmark.org/0.31.2/#link-destination |
Describe the bug
context
Formating status badges from Azure, just copy paste the provided code by Azure devops
expectation
keep it as it is:
[![Build Status](https://dev.azure.com/Lightning-AI/lightning/_apis/build/status%2Fpytorch-lightning%20(GPUs)?branchName=master)](https://dev.azure.com/Lightning-AI/lightning/_build/latest?definitionId=24&branchName=master)
bug
with added <> it is not rendered as image
Reproduce the bug
using pre-commit hook:
List your environment
No response
The text was updated successfully, but these errors were encountered: