Fix a PHP8 TypeError in 10up/simple-local-avatars #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaincuvelier
approved these changes
Jan 19, 2023
mikelittle
reviewed
Jan 19, 2023
|
True, I saw your comment on the PR. Personally I wouldn't be too concerned about that as Core does: Inside wp_get_attachment_url, so it shouldn't be a problem other than store a "dirty" ID in the metadata perhaps. Not sure what use case would lead to that. I don't see this as a good candidate to divert from upstream, so I'm inclined to leave as is until/unless the upstream project gets the better patch. Let me know if you strongly feel otherwise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a TypeError with PHP8 that's been fixed upstream and released in a newer version (with other changes) which we'll ship with v14. This PR backports the fix alone to v13.
See: