You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Flamegraphs which are generated using samples from Excimer (Altis v12+) and XHProf (Altis up to v11) don't show function parameter information (as expected). It would be really very useful if the first parameter passed in calls to do_action() and apply_filters() was stored in the sampling data and exposed in the flamegraphs. This requires a change to the underlying extension(s) but I've opened the ticket here for tracking purposes.
This would allow developers to more easily pinpoint which actions and filters are having performance problems without having to work backwards from the action and filter callbacks. Obviously it's the callbacks themselves that introduce performance issues, but being able to quickly identify which action or filter has problematic callbacks attached to it would ease subsequent debugging, particularly as issues are fixed and wall times are reduced.
In XHProf this is already the case for require/include* calls which show up as eg. require_once::path/to/file.php. It would be great to see WP_Hook::do_action::admin_init instead of just WP_Hook::do_action. I've not yet tested Excimer to see whether it does the same.
Ideally the list of functions or methods which have their first parameter included as part of the sampling data would be configurable in userland at runtime. Here's how this is managed in Query Monitor which actually supports showing more than one parameter in its output.
Joe mentioned this may be easier to achieve with Excimer than with XHProf. Either way, it needs someone with some solid C skills to modify the extension.
The text was updated successfully, but these errors were encountered:
Flamegraphs which are generated using samples from Excimer (Altis v12+) and XHProf (Altis up to v11) don't show function parameter information (as expected). It would be really very useful if the first parameter passed in calls to
do_action()
andapply_filters()
was stored in the sampling data and exposed in the flamegraphs. This requires a change to the underlying extension(s) but I've opened the ticket here for tracking purposes.This would allow developers to more easily pinpoint which actions and filters are having performance problems without having to work backwards from the action and filter callbacks. Obviously it's the callbacks themselves that introduce performance issues, but being able to quickly identify which action or filter has problematic callbacks attached to it would ease subsequent debugging, particularly as issues are fixed and wall times are reduced.
In XHProf this is already the case for
require/include*
calls which show up as eg.require_once::path/to/file.php
. It would be great to seeWP_Hook::do_action::admin_init
instead of justWP_Hook::do_action
. I've not yet tested Excimer to see whether it does the same.Ideally the list of functions or methods which have their first parameter included as part of the sampling data would be configurable in userland at runtime. Here's how this is managed in Query Monitor which actually supports showing more than one parameter in its output.
Joe mentioned this may be easier to achieve with Excimer than with XHProf. Either way, it needs someone with some solid C skills to modify the extension.
The text was updated successfully, but these errors were encountered: