Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespaces: S3 Console link is generated with a local url #395

Open
1 task
mikelittle opened this issue Aug 2, 2022 · 0 comments
Open
1 task

Codespaces: S3 Console link is generated with a local url #395

mikelittle opened this issue Aug 2, 2022 · 0 comments
Labels
bug Existing functionality isn't behaving as expected should have Should be done, medium priority for now

Comments

@mikelittle
Copy link
Contributor

mikelittle commented Aug 2, 2022

Running Altis on Codespaces makes it generate a local URL for the S3 console under the Tools menu.

Running locally it generates the link with a new altis.dev subdomain in the format s3-console-[generated-hostname].altis.dev. It presumably adds a mapping into the Traefik proxy container to connect this to the S3 container.

However on Codespaces it generates the link as http://s3-console-localhost/ which I suspect is some old pre- Traefik proxy version of the functionality.

Note, I don't think there is an option in Codespaces to generate a different subdomain from the one Codespaces gives you. However, the Kibana and Mailhog links are generated as subdirectories of the main hostname, which are then mapped in the proxy to the relevant container. I expect the S3 console could be treated the same.

This is likely related to the error message documented here https://github.com/humanmade/product-dev/issues/1171

Acceptance criteria:

  • The link to Tools > S3 Console is generated correctly so that it works.
@mikelittle mikelittle added bug Existing functionality isn't behaving as expected should have Should be done, medium priority for now labels Aug 2, 2022
@veselala veselala added this to the v12 minor issues milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected should have Should be done, medium priority for now
Projects
None yet
Development

No branches or pull requests

2 participants