Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version of Requests dependency loaded #404

Open
1 task
kovshenin opened this issue Aug 16, 2022 · 2 comments
Open
1 task

Incorrect version of Requests dependency loaded #404

kovshenin opened this issue Aug 16, 2022 · 2 comments
Labels
bug Existing functionality isn't behaving as expected

Comments

@kovshenin
Copy link
Contributor

I've been working through various PHP 8.1 related issues, and one thing I noticed is that due to a dependency is this module, WordPress core loads an incorrect version of the Requests library:

[327] => /usr/src/app/wordpress/wp-includes/class-wp-http.php
[328] => /usr/src/app/vendor/rmccue/requests/library/Requests.php

This is because class-wp-http.php calls class_exists on Requests, causing the autoloader to kick in and load the one from vendor, instead of the version shipped with WordPress core. The dependency comes from:

  • altis/dev-tools -> lucatume/wp-browser
  • lucatume/wp-browser -> wp-cli/wp-cli
  • wp-cli/wp-cli -> rmccue/requests

Acceptance criteria:

  • WordPress should load the Requests library bundled with Core
@kovshenin kovshenin added bug Existing functionality isn't behaving as expected to refine Issues needing refinement. labels Aug 16, 2022
@veselala
Copy link

veselala commented Aug 17, 2022

The team presented on the refinement today 17 Aug 22 roughly estimated the work need for this bug should be 5 SP.
@jerico @wisyhambolu we moved this one to the Backlog.

@veselala veselala removed the to refine Issues needing refinement. label Aug 17, 2022
@rmccue
Copy link
Member

rmccue commented Aug 17, 2022

I think this is something WordPress needs to fix as well fwiw, we won't be the only ones hitting this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

No branches or pull requests

3 participants