-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to override default site path #745
Comments
This looks like the main place we generate the URL: altis-local-server/inc/composer/class-command.php Lines 1143 to 1160 in 3b492e9
However, this is also used in the Docker compose generator for the Tachyon URL, so overriding this would break Tachyon URLs (e.g. would be |
Hey team! Please add your planning poker estimate with Zenhub @jerico @kovshenin @mikelittle @wisyhambolu |
Please add your planning poker estimate with Zenhub @filter182 |
@ferschubert-hm @filter182 Please add you planning poker estimate |
@mikelittle Please add the note how to set it up on Altis |
For sites where the default site isn't the root of the local URL, it'd be useful to have a way to override the default that we provide to
wp-cli
. e.g. if your default site is atexample.altis.dev/en/
, you currently need to pass the URL every time.I'd suggest we add a
default_site_url
option (e.g."default_site_url": "https://example.altis.dev/en/"
), or adefault_site_path
option (e.g."default_site_path": "/en/"
) to override this.Acceptance Criteria
"default_site_url": "example.altis.dev/en"
incomposer.json
,composer server cli
commands work without passing--url
.composer.json
,composer server cli
commands use a default URL based on the domain setting--url
flag for a different sub site still works.example.altis.dev/tachyon
and continue to function./
and/en/
to check the default is working. (No automated testing required, as we don't have a framework in place.)For Altis Team Use
Ready for Work Checklist
Is this ticket ready to be worked on? See
the Play Book Definition of Ready.
Completion Checklist
Is this ticket done? See
the Play Book Definition of Done.
backport
labels been added to the PR?The text was updated successfully, but these errors were encountered: