Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate unsigned bioauth extrinsics via ValidateUnsigned #1369

Open
quasiyoke opened this issue Dec 16, 2024 · 1 comment
Open

Validate unsigned bioauth extrinsics via ValidateUnsigned #1369

quasiyoke opened this issue Dec 16, 2024 · 1 comment
Labels
substrate Related to substrate

Comments

@quasiyoke
Copy link
Contributor

Observed

We validate unsigned bioauth extrinsics via SignedExtension. The ValidateUnsigned impl contains just a stub.

Expected

We should stop relying on validating unsigned bioauth extrinsics via SignedExtension and validate them in ValidateUnsigned:

  1. it is more specific,
  2. the Substrate continues to support the ValidateUnsigned trait (parse expand).
@quasiyoke quasiyoke added the tech debt Technical debt label Dec 16, 2024
@MOZGIII
Copy link
Contributor

MOZGIII commented Dec 16, 2024

Let's discuss what are the implications of altering the signed extensions list are before working on this task.

@MOZGIII MOZGIII added substrate Related to substrate and removed tech debt Technical debt labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
substrate Related to substrate
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MOZGIII @quasiyoke