Documentation: gort digispark install does more than just downloading the software #55
Labels
Comments
|
Hi @christophberger you are indeed correct, seems like this line of code https://github.com/hybridgroup/gort/blob/master/commands/digispark.go#L42 should be removed. Want to create a PR with that change? :) |
|
Sure. Shall I create the PR against the dev branch, since the fix does change the behavior? |
|
Yes, please, and thank you! |
|
Looks like dev is behind master. digispark.go still contains the old invalid urls to littlewire.cc on dev. What's the best way to move forward? |
|
I just rebased master into dev, so you should be good to go now. Sorry about that. |
christophberger
added a commit
to christophberger/gort
that referenced
this issue
Jul 26, 2017
…cs say Signed-off-by: christophberger <[email protected]>
|
No problem. I created a PR just now. |
deadprogram
added a commit
that referenced
this issue
Jul 26, 2017
Fix issue #55 - go digispark install does more than the docs say
|
Thanks for the PR. I will leave the issue open until the next release of Gort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Minor issue.
gort's help text says:
but actually
go digispark installdoes both steps in one: install software to upload firmware to Digispark, AND upload firmware (littlewire) to Digispark.So the actual behavior is not in line with the help text.
The text was updated successfully, but these errors were encountered: