Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old gmkit test.wav? #1137

Closed
oddtime opened this issue Jan 29, 2021 · 5 comments
Closed

old gmkit test.wav? #1137

oddtime opened this issue Jan 29, 2021 · 5 comments
Assignees

Comments

@oddtime
Copy link
Contributor

oddtime commented Jan 29, 2021

Hi guys
I was tryng to solve a unit test fail and I listened to a file that seems using the old gmkit: hydrogen/src/tests/data/functional/test.wav

@theGreatWhiteShark
Copy link
Contributor

I will look into it

@theGreatWhiteShark theGreatWhiteShark self-assigned this Jan 30, 2021
@theGreatWhiteShark
Copy link
Contributor

This was actually a legit fail.

The new pan calculation yields slightly different results since it's dividing two floats with non-zero content all the way to the last digit and causes some truncation. But this should not be audible because it only introduces changes to the audio output at the 6-8 decimal place.

@oddtime
Copy link
Contributor Author

oddtime commented Feb 1, 2021

I assume this is related to #1061.
But what about this file? I removed it and all the tests do pass

@theGreatWhiteShark
Copy link
Contributor

But what about this file? I removed it and all the tests do pass

Okay. Maybe I misunderstood the purpose of this issue. The file is indeed redundant. I removed it in 1722223.

@oddtime
Copy link
Contributor Author

oddtime commented Feb 2, 2021

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants