Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for unique_id in clip_polygon #143

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Bugfix for unique_id in clip_polygon #143

merged 4 commits into from
Sep 3, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Aug 29, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • When using Query, space gets assigned a unique_id: None if none are provided by the user. Thus, the line in clip_polygon was always True.

Does this PR introduce a breaking change?

Other information:

CHANGELOG.rst Outdated Show resolved Hide resolved
@RondeauG RondeauG merged commit 7749168 into main Sep 3, 2024
17 checks passed
@RondeauG RondeauG deleted the fix_uniqueid branch September 3, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants