Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Helper bot, fast-forward cookiecutter #156

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Sep 23, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Enables the Hydrologie Helper Bot to push signed commits to main
  • Fast-forwards the cookiecutter
  • Pins and synchronizes several dependencies

Does this PR introduce a breaking change?

No.

Other information:

"Why use a helper bot?"

Glad you asked. The commits that are coming from the workflow currently are "borrowing" a token I made then overwriting the committer information and, as such, the GPG signature is invalid. For security purposes, this makes it look like someone stole my account and committed changes pretending to be someone else, which is effectively what it is doing.

The helper bot is a verified way of indicating that these commits are genuine and coming from a verified source (by way of GPG signature). The bot makes a one-time-use token, creates a commit with it, pushes the changes, then destroys that token so that the risk of it leaking is diminished.

@Zeitsperre Zeitsperre changed the title use GitHub Helper bot for bumpversion workflow, remove obsolete workf… Use GitHub Helper bot, fast-forward cookiecutter Sep 23, 2024
@github-actions github-actions bot added CI Continuous Integration docs labels Sep 23, 2024
@Zeitsperre Zeitsperre merged commit 7dcaf41 into main Sep 24, 2024
18 checks passed
@Zeitsperre Zeitsperre deleted the use-helper-bot branch September 24, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants