Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use install-esmf-action #31

Merged
merged 9 commits into from
Dec 1, 2023
Merged

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Oct 13, 2023

With this PR, xdatasets testing now no longer requires conda-forge (at least on GitHub)

Changes

  • GitHub CI now uses https://github.com/esmf-org/install-esmf-action in order to build ESMF on GitHub directly
    • This action uses caching, so it should be very quick to run after the first time it is triggered (cache remains for 7 days)
  • The tox.ini now requires ESMF to be installed and for the environment variable ESMF_VERSION to be present in the shell or be passed to tox via $ export ESMF_VERSION=vX.Y.Z tox

@Zeitsperre Zeitsperre added the enhancement New feature or request label Oct 13, 2023
@Zeitsperre Zeitsperre self-assigned this Oct 13, 2023
Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastienlanglois, ça me semble bon, si jamais tu veux regarder et intégrer ces changements.

Base automatically changed from use-cruft to master November 30, 2023 21:53
@RondeauG
Copy link
Collaborator

RondeauG commented Dec 1, 2023

Just so we don't forget, we need to adjust bump-my-version so changes in pyproject.toml don't trigger version changes.

# Conflicts:
#	.github/workflows/bump-version.yml
#	.github/workflows/gh-pages.yml
#	.github/workflows/main.yml
#	.github/workflows/publish-pypi.yml
#	.github/workflows/tag-testpypi.yml
#	setup.py
#	tox.ini
@sebastienlanglois sebastienlanglois merged commit 4197f96 into master Dec 1, 2023
7 checks passed
@Zeitsperre Zeitsperre deleted the use-esmf-install-action branch December 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants